Does cup have a short sound?

Yes, the "u" in "cup" has a short sound, like the "u" in "sun" or "fun".

It's not the long "u" sound like in "flute" or "cube".