Does neighbor have a short sound?

Yes, the "gh" in "neighbor" has a short sound. It's pronounced like the "g" in "go" or "get". So, "neighbor" is pronounced "NAY-bur".