Do neighbor have a long sound?

The word "neighbor" does not have a long sound. It has a short "e" sound in the first syllable ("neigh") and a short "o" sound in the second syllable ("bor").

Therefore, "neighbor" is pronounced with two short vowel sounds.