Is this how you spell whoop cushion that makes a fart sound?

Yes, "whoopie cushion" is the correct spelling for a device that makes a fart sound.

You could also spell it "whoopie cushion" or "whoopie-cushion," but "whoopie cushion" is the most common spelling.