Is the a in leaf long or short?

This is because the "a" is followed by a consonant ("f"). In English, the "a" sound is typically short when it is followed by a consonant.